Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ProxySQL_Uptime status. It is ProxySQL running time (unit: seconds) #947

Closed
wants to merge 1 commit into from

Conversation

taylor840326
Copy link

Sometimes I want to get some metrics:
for example:

the number of Client_Connections_created per second
the number of Client_Connections_aborted per second
, etc.

But "show mysql status" command only output total number.
So. I add this “ProxySQL_Uptime” metrics.

@renecannao
Copy link
Contributor

Lei,
Thank you for the PR.
Although, I will close this PR and implement it in a different way.
A bit more context on why I will implement differently:

  • the information is already available here : it only needs to be made available in SHOW MYSQL STATUS
  • time() is not safe: if someone change the clock of the system, the result will be incorrect. This is why the current solution already uses monotonic time.

Thanks

@taylor840326
Copy link
Author

@renecannao
👍 OK! 🌹

renecannao added a commit that referenced this pull request Mar 9, 2017
renecannao added a commit that referenced this pull request Mar 9, 2017
@renecannao
Copy link
Contributor

Feature introduce in both 1.3.5 and 1.4.0 , both to be released

@renecannao renecannao closed this Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants