Fix bug in list_hp_retire function #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@linD026, Please help review this proposed change. |
jserv
requested changes
Apr 23, 2022
There was a problem hiding this comment.
Read https://cbea.ms/git-commit/ carefully. Then, write down informative commit message(s).
kevinshieh0225
changed the title
|
You should use |
In hp_list project's function : list_hp_retire, it attempts to reorganize retire list while the object is deleting. However, as I see, the origin code doesn't adjust the index simultaneously, which will skip track of the object origin from &rl->list[iret + 1]. Change the behavior as: - If reorganize happens, keep the same index for next iteration. - Else, index++.
|
In my opinion, the original code might be a bug. |
|
I think the change is correct since the original code skips the next element if a deletion happens. |
|
Thank @kevinshieh0225 for contributing. The git commit message was amended upon the review of @linD026 and @kdnvt . |
linD026
pushed a commit
to linD026/concurrent-programs
that referenced
this pull request
May 8, 2022
In list_hp_retire function of hp_list, the original code would skip the next element if a deletion happens. It was incorrect because of its neglect to adjust the index simultaneously, skipping track of the object origin from &rl->list[iret + 1]. This patch then changed the behavior as: - If reorganize happens, keep the same index for next iteration. - Else, index++.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In hp_list project's function : list_hp_retire, it attempt to reorganize retire list while the object is deleting.
However, as I see, the origin code doesn't adjust the index simultaneously, which will skip track of the object
origin from &rl->list[iret + 1]. I'm not sure whether the behavior was originally intended or not.