-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep prebuilt ELF files up to date #451
Comments
I think it is time to handle the prebuilt executable files in a more elegant way. The proposed change is to separate the executable files existing in the The expected flow:
@ChinYikMing did some prior work for rv32emu-bench. |
In this work flow, the deploy-wasm CI will be affected such that it cannot monitor that whether the built elf has been changed. The possible adaption could be monitor the source files of the executable files. If the source files change, the deploy-wasm CI can use the |
The file |
#455 is also impacted by this elf recompilation delay. I have done the compiler packaging and recompiling sail reference model before actually, and it's done in a container, so I can quickly help on this matter. However I recall that using a newer toolchain to build rv32emu at the time would cause the tests to fail, also, building a reference model using the latest dependencies would cause some tests to fail, too. So there might be some work to do... All the dockerfile that I worked on is under the directory I will update both Dockerfiles and push to DockerHub in the meantime, as #455 requires updating the compiler toolchain and recompiling the benchmark elfs, otherwise, our benchmarking CI is currently broken. |
Latest toolchain image and sail reference model image have been updated to DockerHub I will create 2 PRs
|
Due to #444 , we need to update the binary with the new toolchain.
The text was updated successfully, but these errors were encountered: