New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems to enable feature defined in a module different from the current one #742
Comments
The bug doesn't occur with the devel branch. I close it |
After more detailed tests we have realized that the problem still occurs. |
Hi, can you provide some example? If I understand it correctly, the expected behavior is that |
Hi Radek
thanks a lot for your reply.
Let me better explain the issue I'm facing.
My purpose was to define all the features I need in a yang file
(tiesse.features.yang). The yang file is properly installed. For example
this is a snippet of the tiesse-features yang file
feature model-lx {
description "todo";
}
feature model-fe {
description "todo";
}
feature *model-4p* {
description "todo";
}
feature model-8p {
description "todo";
}
In a different file (tiesse-ethernet) I want to use 'if-feature'
statement to enable some more containers/leaves based on the model
feature detected
import tiesse-features {
prefix features;
}
container bplane {
if-feature *features:model-4p*;
leaf speed {
type string;
}
}
At boot time depending on the board model detected some features are
enabled by sysrepoctl. I can see that '*model-4p*' has been properly
enabled by sysrepoctl
*tiesse-features* | 2017-03-06 |
| | | ik-ike model-is-0760-44 *model-4p* model-fe
Anyway the bplane container is not enabled and any write attempt fails.
If I create a local version of the model-4p feature in the same file
where it will be used by 'if-feature', I can write/read the leaf 'speed'
within 'bplane' container.
If you need I can provide you with my yang files.
thanks a lot
best regards
fabio
…On 10/04/2017 10:12, Radek Krejčí wrote:
Hi, can you provide some example? If I understand it correctly, the
expected behavior is that |sysrepoctl| report error because the
feature is not defined in the module you provided in the |--module|
argument, right?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#742 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFpJnTwcZJdmcd_aSDpn1JC2Cf74g64Aks5rueSJgaJpZM4MHcCw>.
|
How do you call |
~ # sysrepoctl --feature-enable=model-4p --module=tiesse-features
Enabling feature 'model-4p' in the module 'tiesse-features'.
Operation completed successfully.
…On 10/04/2017 11:15, Radek Krejčí wrote:
How do you call |sysrepoctl|?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#742 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFpJnYX4rdJbE-Km5utaHUqPFzQrgK9Mks5rufMsgaJpZM4MHcCw>.
|
When I try to set the speed leaf under bplane container I have the following error messages: [INF] (rp_dt_set_item_wrapper:575) Set item request running datastore, xpath: /tiesse-ethernet:ethernet/bplane/speed from the client trying to set the leaf hope this can help |
Please try to review/test the fix in pull request #783 |
Hi Radek
I have merged the patch and now it works fine!
Let me double check with more tests but the first results are really good
thanks
fabio
…On 10/04/2017 16:25, Radek Krejčí wrote:
Please try to review/test the fix in pull request #783
<#783>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#742 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFpJnVEPPa1vvlUch-s03Ustta9tcBbSks5rujvbgaJpZM4MHcCw>.
|
This issue can be closed |
Hi all
I have tried to define a new feature in a yang file and then enable the same feature in a different yang file.
The feature has been properly enabled by sysrepoctl, but when I try to set the leaf enabled by if-feature tag the command fails with "Unknown element".
Anyway if I move the feature definition in the same yang file where it is enabled by 'if-feature' statement the operation is successfully completed.
Any suggestion? Has it been fixed in the devel branch?
thanks a lot
best regards
fabio
The text was updated successfully, but these errors were encountered: