make sysrepo connection timeout switchable #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine with the idea, but could you integrate setting the variable into cmake processing? Ideally, I would connect it it somehow with |
…tead of DISABLE_REQUEST_TIMEOUTS
|
Please check the update. Thanks, |
rkrejci
reviewed
Apr 20, 2018
CMakeLists.txt
Outdated
| @@ -194,6 +194,10 @@ set(NOTIF_AGE_TIMEOUT 60 CACHE INTEGER | |||
| set(NOTIF_TIME_WINDOW 10 CACHE INTEGER | |||
| "Time window (in minutes) for notifications to be grouped into one data file (larger window produces larger data files).") | |||
|
|
|||
| if(REQUEST_TIMEOUT EQUAL "0" AND NOT LONG_REQUEST_TIMEOUT EQUAL "0") | |||
| message(FATAL_ERROR "LONG_REQUEST_TIMEOUT must be 0 when REQUEST_TIMEOUT is 0") | |||
There was a problem hiding this comment.
in this case I would set LONG_REQUEST_TIMEOUT automatically (maybe with some message to get know what it does), on the other hand, I would like to have a test (and error) for the case REQUEST_TIMEOUT > LONG_REQUEST_TIMEOUT.
michalvasko
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
please consider this little modification which makes it possible to disable the connection timeout in the sysrepo client library by compiler switch.
Background:
In low performance environments, sysrepo clients might be too busy to answer in time, if the connection then times out it starts that things get worse. For this reason we want to be able to switch it off (and deal with the consequences, if necessary)
Regards,
Frank