lua: remove bindings #1429
Merged
lua: remove bindings #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we are deprecating the Sysrepo Lua bindings. With the current changes to the Sysrepo C++ bindings we had to use simple wrapper class (ptr class) for the objects returned and sent to the Lua bindings which makes them a bit awkward to use now, the example below: - change = sess:get_change_next(it) + change = sr.ptr(sess:get_change_next(it)) We used Lua bindings for scripting on OpenWrt alongside with Python but now Python is better suited for that. Besides us, we aren't aware of any one using the Lua bindings and they are making the C++/Python bindings harder to maintain. Signed-off-by: Mislav Novakovic <mislav.novakovic@sartura.hr>
michalvasko
approved these changes
Feb 18, 2019
jefferyto
added a commit
to jefferyto/openwrt-packages
that referenced
this pull request
Nov 15, 2019
This change:
* Removes building of Lua bindings. These bindings were already removed
upstream[1].
* Fixes building of Python bindings:
* Fix SWIG_DIR path (note that SWIG_VERSION will need to be updated
whenever the swig package is upgraded)
* Fix Python module paths and filenames
* Packages the Python bindings in a new package (python3-sysrepo) and
builds it by default, instead of depending on a config option.
[1]: sysrepo/sysrepo#1429
Signed-off-by: Jeffery To <jeffery.to@gmail.com>
neheb
pushed a commit
to neheb/packages
that referenced
this pull request
Nov 15, 2019
This change:
* Removes building of Lua bindings. These bindings were already removed
upstream[1].
* Fixes building of Python bindings:
* Fix SWIG_DIR path (note that SWIG_VERSION will need to be updated
whenever the swig package is upgraded)
* Fix Python module paths and filenames
* Packages the Python bindings in a new package (python3-sysrepo) and
builds it by default, instead of depending on a config option.
[1]: sysrepo/sysrepo#1429
Signed-off-by: Jeffery To <jeffery.to@gmail.com>
Lienol
pushed a commit
to Lienol/openwrt-packages
that referenced
this pull request
Dec 8, 2021
This change:
* Removes building of Lua bindings. These bindings were already removed
upstream[1].
* Fixes building of Python bindings:
* Fix SWIG_DIR path (note that SWIG_VERSION will need to be updated
whenever the swig package is upgraded)
* Fix Python module paths and filenames
* Packages the Python bindings in a new package (python3-sysrepo) and
builds it by default, instead of depending on a config option.
[1]: sysrepo/sysrepo#1429
Signed-off-by: Jeffery To <jeffery.to@gmail.com>
Lienol
pushed a commit
to Lienol/openwrt-packages
that referenced
this pull request
Dec 9, 2021
This change:
* Removes building of Lua bindings. These bindings were already removed
upstream[1].
* Fixes building of Python bindings:
* Fix SWIG_DIR path (note that SWIG_VERSION will need to be updated
whenever the swig package is upgraded)
* Fix Python module paths and filenames
* Packages the Python bindings in a new package (python3-sysrepo) and
builds it by default, instead of depending on a config option.
[1]: sysrepo/sysrepo#1429
Signed-off-by: Jeffery To <jeffery.to@gmail.com>
Lienol
pushed a commit
to Lienol/openwrt-packages
that referenced
this pull request
Dec 19, 2021
This change:
* Removes building of Lua bindings. These bindings were already removed
upstream[1].
* Fixes building of Python bindings:
* Fix SWIG_DIR path (note that SWIG_VERSION will need to be updated
whenever the swig package is upgraded)
* Fix Python module paths and filenames
* Packages the Python bindings in a new package (python3-sysrepo) and
builds it by default, instead of depending on a config option.
[1]: sysrepo/sysrepo#1429
Signed-off-by: Jeffery To <jeffery.to@gmail.com>
Lienol
pushed a commit
to Lienol/openwrt-packages
that referenced
this pull request
Feb 2, 2022
This change:
* Removes building of Lua bindings. These bindings were already removed
upstream[1].
* Fixes building of Python bindings:
* Fix SWIG_DIR path (note that SWIG_VERSION will need to be updated
whenever the swig package is upgraded)
* Fix Python module paths and filenames
* Packages the Python bindings in a new package (python3-sysrepo) and
builds it by default, instead of depending on a config option.
[1]: sysrepo/sysrepo#1429
Signed-off-by: Jeffery To <jeffery.to@gmail.com>
Lienol
pushed a commit
to Lienol/openwrt-packages
that referenced
this pull request
Feb 11, 2022
This change:
* Removes building of Lua bindings. These bindings were already removed
upstream[1].
* Fixes building of Python bindings:
* Fix SWIG_DIR path (note that SWIG_VERSION will need to be updated
whenever the swig package is upgraded)
* Fix Python module paths and filenames
* Packages the Python bindings in a new package (python3-sysrepo) and
builds it by default, instead of depending on a config option.
[1]: sysrepo/sysrepo#1429
Signed-off-by: Jeffery To <jeffery.to@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depraced the Sysrepo Lua bindings.
With the current changes to the Sysrepo C++ bindings we had to use
simple wrapper class (ptr class) for the objects returned and sent to
the Lua bindings which makes them a bit awkward to use now, the
example below:
We used Lua bindings for scripting on OpenWrt alongside with Python
but now Python is better suited for that. Besides us, we aren't aware
of any one using the Lua bindings and they are making the C++/Python
bindings harder to maintain.