cpp: Ensure that Trees::tree reuses our reference counter #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code uses Counter instances to work around the std::shared_ptr API design where one cannot really manipulate the reference count from outside. In this context, we however need to ensure that a shared_ptr<Tree> created from within a Trees context reuses the same counter, and that the underlying data structure only gets deleted when the enclosing Trees structure is destroyed. Cc issue sysrepo#366
Current coverage is 85.86% (diff: 100%)@@ devel #367 diff @@
==========================================
Files 29 29
Lines 18280 20187 +1907
Methods 770 948 +178
Messages 0 0
Branches 3130 3720 +590
==========================================
+ Hits 15532 17333 +1801
- Misses 2748 2854 +106
Partials 0 0
|
|
fixed in #375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code uses Counter instances to work around the std::shared_ptr API
design where one cannot really manipulate the reference count from
outside. In this context, we however need to ensure that a
shared_ptr created from within a Trees context reuses the same
counter, and that the underlying data structure only gets deleted when
the enclosing Trees structure is destroyed.
@mislavn , please check issue #366 and ensure that this patch doesn't make the situation worse.