Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters USB devices to not be listed in disk selection dialog. Add a config value to allow USB devices to show in selection dialog. Fixes installation on USB devices. #28

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

happymab
Copy link
Contributor

@happymab happymab commented Jun 4, 2024

This PR fixes the installation on USB devices:

  • USB devices are filtered out by default and not offered as installation devices
  • A new config value allows optionally to disable the USB filter, show USB devices in the selection dialog and allow the installation
  • A change in the mig module fixes the issue with failed installations on USB devices

Added partition info to disk selection dialog. Info added is number of partitions for the disk and label, file system and size of each partition.
…config value to allow USB devices to show in selection dialog. Fixes installation on USB devices.
@sysrich
Copy link
Owner

sysrich commented Jun 10, 2024

Looks good to me but also includes the changes from your other PR

It's good practice to use different branches for each topic so I'm not forced to merge everything all together

I will in this case.. but it will have to wait a few more days so have the time to test it more thoroughly as it's a bigger set of changes now :)

Thanks for the contributions !

@happymab
Copy link
Contributor Author

Right, I branched from the previous branch instead of main. I will keep that in mind next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants