expose heating status/current implements #420 fixes #433 #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFDarter
commented
Jan 26, 2024
syssi
reviewed
Jan 27, 2024
| @@ -556,6 +558,13 @@ void JkBmsBle::decode_jk02_cell_info_(const std::vector<uint8_t> &data) { | |||
| // 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 | |||
| // 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 | |||
| // 0x00 | |||
|
|
|||
| // 224 1 0x01 Heating status 0x00: off, 0x01: on | |||
| this->publish_state_(this->heating_binary_sensor_, (bool) data[224 + offset]); | |||
There was a problem hiding this comment.
At the moment we cannot be sure this byte position applies to JK02_32S frames too. All your devices are so called old style 24S devices?
There was a problem hiding this comment.
Yep, unfortunately i dont have a new style here to test.
But if it works it works and if not it will not brake anything just show the wrong status, same with the heating current.
Do you have any btsnoops of the new style bms?
There was a problem hiding this comment.
I've a BMS here using the new protocol version. It looks like old version. IMO just the firmware (+ protocol version) has changed. My model doesn't have an heater element but I will check the heating current and status. In best case it's 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #420
fixes #433