-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CSV Output from pidstat
#174
Comments
* Bug fix: The 'bytes written', 'bytes read' and 'write bytes cancelled' statistics that were output to CSV were calculated improperly, reporting the cumulative number of bytes since process start, rather than the number of bytes for each sample interval. * Slight refactor to output CSV stats for children, or tasks, based on the `-T` command line option.
Thank you for your contribution.
I didn't have time to google for an explanation. Anyway I mean that I may have other remarks once I know how to fix the problem. Some remarks below may even don't apply if I didn't understand properly how your patch works. So here are several things that you should take into account before this feature can get included in sysstat/pidstat. The idea is to keep consistent with how other options from other sysstat commands work:
But not: |
Hi, Sebastien. Thanks for the comments. I can address some of them. However, my team is trying to use Here's what I have been able to use to check out my feature branch. (I believe your git clone https://github.com/tst-ppenev/sysstat.git
cd sysstat
git checkout '#174-pidstat-csv-output' Q: Are you able to comment on the individual code lines of the pull request at https://github.com/sysstat/sysstat/pull/175/files? |
@sysstat: The reason I added an output file path to the CSV format switch is that I didn't find an easy way to separate the output of E.g., if you create
! /bin/bash
echo "$0:" "The output is standard."
sleep 2
echo "$0:" "The standard is output." and run: pidstat 1 -e /tmp/sample-command.sh > sample-command.pidstat-output.txt You get:
|
Yes, that's why pidstat should display either its standard report or its CSV output, not both. |
@tst-ppenev @sysstat Hi, it sounds good to have CSV output option for pidstat, but how about getting an option also for binary output so that I can postsprocess and make graphs with sadf? My version is 11.3.5-1.fc25. UPDATE: I compled 12.1.4, seems no binary output from pidstat there either. UPDATE2: I'll post a separate issue for pidstat binary output. |
As a
pidstat
user, I would like to be able to receive the statistics for each time period as a CSV file. That makes it easier to graph results, and correlate them with data from profiling tools.Note from issue creator:
I'm not familiar with conventions for contributing to the SysStat project, and I didn't see a developer guide, so this is my best effort to open a ticket and submit a pull request. Advice is appreciated.
The text was updated successfully, but these errors were encountered: