not throwing exceptions, since the annotation processing is not happe…

…ning inside IDEs, instead logging warnings.
systay · Oct 7, 2011 · 6819dfd · 6819dfd
1 parent db0ab69
commit 6819dfd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 15 deletions.
diff --git a/kernel/src/test/java/org/neo4j/metatest/TestJavaTestDocsGenerator.java b/kernel/src/test/java/org/neo4j/metatest/TestJavaTestDocsGenerator.java
@@ -21,7 +21,6 @@
 
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
 
 import java.io.BufferedInputStream;
 import java.io.File;
@@ -32,7 +31,6 @@
 import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
-import org.junit.internal.runners.statements.Fail;
 import org.neo4j.graphdb.GraphDatabaseService;
 import org.neo4j.graphdb.Node;
 import org.neo4j.kernel.impl.annotations.Documented;
@@ -82,19 +80,11 @@ public void can_create_docs_from_method_name() throws Exception
     @Documented( value = "@@snippet1\n" )
     @Test
     @Graph( "I know you" )
-    public void will_complain_about_missing_snippets() throws Exception
+    public void will_not_complain_about_missing_snippets() throws Exception
     {
         data.get();
         JavaTestDocsGenerator doc = gen.get();
-        try
-        {
-            doc.document( directory, sectionName );
-            fail();
-        }
-        catch ( IllegalArgumentException e )
-        {
-            // ok
-        }
+        doc.document( directory, sectionName );
     }
 
     /**

diff --git a/kernel/src/test/java/org/neo4j/test/AsciiDocGenerator.java b/kernel/src/test/java/org/neo4j/test/AsciiDocGenerator.java
@@ -25,6 +25,7 @@
 import java.io.Writer;
 import java.util.HashMap;
 import java.util.Map;
+import java.util.logging.Logger;
 
 import org.neo4j.graphdb.GraphDatabaseService;
 
@@ -41,7 +42,7 @@
 public abstract class AsciiDocGenerator
 {
     private static final String DOCUMENTATION_END = "\n...\n";
-
+    private Logger log = Logger.getLogger( AsciiDocGenerator.class.getName() );
     protected String title = null;
     protected String description = null;
     protected GraphDatabaseService graph;
@@ -170,7 +171,7 @@ protected String replaceSnippets( String description )
             description = replaceSnippet( description, key );
         }
         if(description.contains( SNIPPET_MARKER )) {
-            throw new IllegalArgumentException("missing snippet in " + description);
+            log.severe( "missing snippet in " + description);
         }
         return description;
     }
@@ -183,7 +184,7 @@ private String replaceSnippet( String description, String key )
             description = description.replace( snippetString + "\n",
                     snippets.get( key ) );
         } else {
-            throw new IllegalArgumentException( "could not find " + snippetString + "\\n in "+ description );
+            log.severe( "could not find " + snippetString + "\\n in "+ description );
         }
         return description;
     }