Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Angular 16 #127

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Update to Angular 16 #127

merged 5 commits into from
Oct 16, 2023

Conversation

fjaguado
Copy link
Contributor

No description provided.

@fjaguado fjaguado added this to In progress in 16.x.x - Angular 16 via automation Oct 11, 2023
@fjaguado fjaguado self-assigned this Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b18f3aa) 69.16% compared to head (e2b98b6) 69.16%.

❗ Current head e2b98b6 differs from pull request most recent head dac2105. Consider uploading reports for the commit dac2105 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   69.16%   69.16%           
=======================================
  Files           7        7           
  Lines         334      334           
  Branches       74       74           
=======================================
  Hits          231      231           
  Misses         86       86           
  Partials       17       17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joaquimvila
joaquimvila requested changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@joaquimvila joaquimvila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss updating the package.json file under "projects/systelab-translate" folder.
Notice the range of accepted Angular versions should be updated there.

package.json Outdated Show resolved Hide resolved
@fjaguado
Update peerDependencies
30a58c9 
Remove protractor from package.json
@jserra91 jserra91 self-requested a review October 13, 2023 12:00
@fjaguado fjaguado merged commit 47e587d into master Oct 16, 2023
6 checks passed
16.x.x - Angular 16 automation moved this from In progress to Done Oct 16, 2023
@fjaguado fjaguado mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jserra91 jserra91 jserra91 approved these changes

@oGalceran1 oGalceran1 oGalceran1 approved these changes

@RubKrmon RubKrmon RubKrmon approved these changes

@joaquimvila joaquimvila joaquimvila approved these changes

Assignees

@fjaguado fjaguado

Labels
enhancement
Projects
16.x.x - Angular 16
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fjaguado @jserra91 @oGalceran1 @RubKrmon @joaquimvila