Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Considered angular routing when calculating prefix used to load bundl… #13

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Conversation

joaquimvila
Copy link
Contributor

Fix of issue #11 for Angular 5

@codecov-io
Copy link

Codecov Report

Merging #13 into 3.1.2 will decrease coverage by 0.4%.
The diff coverage is 38.46%.

Impacted file tree graph

@@           Coverage Diff            @@
##           3.1.2     #13      +/-   ##
========================================
- Coverage   55.5%   55.1%   -0.41%     
========================================
  Files          9       9              
  Lines        463     470       +7     
  Branches      39      42       +3     
========================================
+ Hits         257     259       +2     
- Misses       191     196       +5     
  Partials      15      15
Impacted Files Coverage Δ
...pp/systelab-translate/systelab-translate.module.ts 93.33% <100%> (+0.47%) ⬆️
...elab-translate/LocalizableTranslateStaticLoader.ts 57.89% <20%> (-7.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a41cb9e...89b7699. Read the comment docs.

@alfonsserra alfonsserra merged commit 3324cf4 into systelab:3.1.2 Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants