Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the library to use the structure proposed by cli. #32

Merged
merged 24 commits into from
Mar 25, 2020

Conversation

alfonsserra
Copy link
Contributor

No description provided.

@alfonsserra alfonsserra marked this pull request as ready for review March 14, 2020 11:11
script:
- ng test --watch=false --code-coverage
script:
- npm run test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order is different in systelab-preferences

Copy link
Contributor

@vinyulis vinyulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!!. Thanks!!

@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #32 into master will increase coverage by 6.78%.
The diff coverage is 54.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   49.14%   55.92%   +6.78%     
==========================================
  Files           8        8              
  Lines         407      363      -44     
  Branches       42       67      +25     
==========================================
+ Hits          200      203       +3     
+ Misses        195      130      -65     
- Partials       12       30      +18     
Impacted Files Coverage Δ
...rojects/systelab-translate/src/lib/i18n.service.ts 71.01% <ø> (ø)
...s/systelab-translate/src/lib/number-format.pipe.ts 100.00% <ø> (ø)
...lab-translate/src/lib/systelab-translate.module.ts 100.00% <ø> (ø)
...jects/systelab-translate/src/lib/translate.pipe.ts 33.33% <ø> (ø)
...nslate/src/lib/LocalizableTranslateStaticLoader.ts 50.00% <50.00%> (ø)
...translate/src/lib/decimal-format/decimal-format.ts 54.61% <54.61%> (ø)
.../systelab-translate/src/lib/date-util/date-util.ts 42.20% <55.55%> (ø)
projects/systelab-translate/src/test.ts 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6163f5...dd24fac. Read the comment docs.

@alfonsserra alfonsserra merged commit e7cc494 into master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants