Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 11 upgrade #51

Merged
merged 4 commits into from
Jan 21, 2021
Merged

Angular 11 upgrade #51

merged 4 commits into from
Jan 21, 2021

Conversation

olgapuig
Copy link
Contributor

@olgapuig olgapuig commented Jan 18, 2021

Angular 11 Upgrade
Guide: https://update.angular.io/?l=3&v=10.2-11.0

Use 'karma-coverage' because 'karma-coverage-istanbul-reporter' usage has been deprecated since version 11

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #51 (0e37e43) into master (c10b56b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   57.63%   57.63%           
=======================================
  Files           8        8           
  Lines         380      380           
  Branches       74       74           
=======================================
  Hits          219      219           
  Misses        129      129           
  Partials       32       32           
Impacted Files Coverage Δ
...s/systelab-translate/src/lib/number-format.pipe.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c10b56b...0e37e43. Read the comment docs.

@olgapuig
Copy link
Contributor Author

The test execution fails because 'karma-coverage-istanbul-reporter' usage has been deprecated since version 11. I'm going to fix it.

@alfonsserra alfonsserra merged commit 30a0da9 into master Jan 21, 2021
@olgapuig olgapuig mentioned this pull request Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants