Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: opt out of typechecking styled.X when as prop is given #1138

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

hasparus
Copy link
Member

@hasparus hasparus commented Aug 17, 2020

The type definition for ThemedComponent was missing a default = undefined.

This fixes a bug for TS users in 0.4.0-rc.3.

AnyComponentProps is a fix for props spreading bug we have, i.e. one can't spread props: ComponentPropsWithoutRef<typeof Styled.p> onto Styled.p. It can be worked around with ComponentPropsWithoutRef<"p">, but it's still inconvenient.

@hasparus hasparus requested a review from jxnblk August 17, 2020 08:24
@jxnblk jxnblk merged commit dd471a2 into system-ui:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants