Return negative number from lookup if theme value is a number #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/systemui/theme-ui/Ca7gEpVkfVcGGcqFgbrTJzqTJ6xk |
|
Solid PR @kenny-f! Thanks! |
|
Released with 0.7.3 |
@hasparus Thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a previous pull request #865 I added the feature to allow negative lookups of theme objects to be resolved.
eg:
given
{ space: { s: '8px' }andsx={{ margin: '-s' }}would be resolved tomargin: '-8px'however when the theme value is a
numberit resolves to'-8'(string) instead of-8(number) and then in the browser you seemargin: -80instead ofmargin: -80pxThis pr will fix this by checking if the theme value type is a number, and if it is will return a number.