Update global-styles.mdx #1858
Merged
Update global-styles.mdx #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a note for people updating. I ran into an issue with `theme` not being defined and took me a while to realise the imports had changed. No worries if you don't wish to add this, but it might stop someone else pulling their hair out.
Fix invalid formatting. Clean up a little bit.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/systemui/theme-ui/Cg5NMLCxvkkzTrFRarWHZNHuk9w2 |
|
I like it. Do you think we should go bigger and link Migration Notes for 0.6 in there? |
|
Thanks for the response. I've added the update.
|
|
Thanks for your work, @jordie23! |
hasparus
approved these changes
Jul 8, 2021
This was referenced Jul 27, 2021
|
🚀 PR was released in |
hasparus
added
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note for people updating. I ran into an issue with the
themearg not being defined after I updated from theme-ui 0.3.1 and took me a while to realise the imports had changed.No worries if you don't wish to add this, but it might stop someone else pulling their hair out.