Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converted preset-base from .js to .ts #675

Merged
merged 1 commit into from
Feb 18, 2020
Merged

converted preset-base from .js to .ts #675

merged 1 commit into from
Feb 18, 2020

Conversation

Zolwiastyl
Copy link
Contributor

@Zolwiastyl Zolwiastyl commented Feb 16, 2020 •
edited
Loading

Hi, this is my first PR and it is part of #668 .

mxstbr
mxstbr approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 👏 👏 Love how the exported index.d.ts file has the perfectly typed object.

Thanks for doing this! 🔥

@mxstbr mxstbr merged commit 1a5db54 into system-ui:master Feb 18, 2020
@mxstbr mxstbr mentioned this pull request Feb 18, 2020
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxstbr mxstbr mxstbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zolwiastyl @mxstbr