@theme-ui/match-media : TypeScript conversion #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
commented
Feb 20, 2020
| @@ -511,7 +511,7 @@ export type ColorMode = { | |||
| } | |||
|
|
|||
| export interface Theme { | |||
| breakpoints?: ObjectOrArray<number | string | symbol> | |||
| breakpoints?: Array<string> | |||
There was a problem hiding this comment.
According to the documentation this is only ever a string[]. Also was necessary to fix type issues in match-media
There was a problem hiding this comment.
I'd guess the types for this might have originated in older versions of Styled System FWIW -- might be some other holdovers from that theme interface to keep an eye out for
LekoArts
commented
Feb 20, 2020
| }, | ||
| "publishConfig": { | ||
| "access": "public" | ||
| }, | ||
| "devDependencies": { | ||
| "react": "^16.9.0", | ||
| "theme-ui": "^0.3.1" | ||
| "@theme-ui/core": "^0.3.1", |
There was a problem hiding this comment.
Switch out theme-ui for /core (to access Theme)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
match-mediapackage to TS. Didn't touch the tests yet.Part of #668