Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: add root tsconfig #700

Merged
merged 1 commit into from
Mar 1, 2020
Merged

task: add root tsconfig #700

merged 1 commit into from
Mar 1, 2020

Conversation

timReynolds
Copy link
Contributor

As mentioned in this comment as part of #668 it would be better to extend a core tsconfig file than duplicate the settings in every package.

This PR introduces that change placing the core settings in a new tsconfig.json at the root level and then extended everywhere else.

As strict mode was set in most packages I've included it in the root settings and disabled it the two places (core & css) which previously didn't have it set. You'll probably want to fix these packages in separate PRs.

I wasn't clear if the intent was to have to root file called .tsconfig.json as mentioned in the comment, it didn't feel like the convention so it's currently tsconfig.json happy to change it if you'd like.

I wasn't sure how to test this, test don't seem to be working, so I executed yarn prepare which passes in all packages.

Copy link
Member

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you so much for doing this! 💯 This looks great

@mxstbr mxstbr merged commit 04c3cb5 into system-ui:master Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants