Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this comment as part of #668 it would be better to extend a core tsconfig file than duplicate the settings in every package.
This PR introduces that change placing the core settings in a new
tsconfig.json
at the root level and then extended everywhere else.As strict mode was set in most packages I've included it in the root settings and disabled it the two places (core & css) which previously didn't have it set. You'll probably want to fix these packages in separate PRs.
I wasn't clear if the intent was to have to root file called
.tsconfig.json
as mentioned in the comment, it didn't feel like the convention so it's currentlytsconfig.json
happy to change it if you'd like.I wasn't sure how to test this, test don't seem to be working, so I executed
yarn prepare
which passes in all packages.