Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gatsby-theme-code-recipes): convert to typescript #709

Closed
wants to merge 9 commits into from
Closed

refactor(gatsby-theme-code-recipes): convert to typescript #709

wants to merge 9 commits into from

Conversation

velein
Copy link

@velein velein commented Feb 23, 2020

Part of #668

Converts gatsby-theme-code-recipes to Typescript. I've double checked if this running correctly on docs (docs are using this package as dependency)

Might be a good idea to make additional tweaks by adding strict: true and type any props. I can try add that if you don't have anything against it.

@velein velein requested a review from jxnblk February 23, 2020 12:53
@mxstbr mxstbr mentioned this pull request Mar 1, 2020
32 tasks
@mxstbr
Copy link
Member

mxstbr commented Mar 1, 2020

Might be a good idea to make additional tweaks by adding strict: true and type any props. I can try add that if you don't have anything against it.

Yes please!! 🙏

@velein
Copy link
Author

velein commented Mar 7, 2020

Done @mxstbr
BTW sorry I've mistakenly set Brent as a reviewer and cannot add you now 🤦‍♂

@vercel
Copy link

vercel bot commented Dec 14, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/systemui/theme-ui/stg60ssij
✅ Preview: Failed

@hasparus hasparus changed the base branch from master to develop December 14, 2020 09:12
@lachlanjc
Copy link
Member

Thank you for your contribution here! This package has since been removed from Theme UI—I’m sorry this waited so long with such an unfulfilling finish, but we’d absolutely welcome other contributions. <3

@lachlanjc lachlanjc closed this Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants