Convert gatsby-theme-ui-blog to TypeScript #711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasparus
requested changes
May 10, 2020
There was a problem hiding this comment.
I think it's okay after fixing conflicts and the two small issues I mentioned, but let's wait to see how we're going to approach TS in themes/plugins (#668 (comment))
| "@theme-ui/preset-base": "^0.3.0", | ||
| "gatsby-plugin-react-helmet": "^3.1.3", | ||
| "gatsby-plugin-theme-ui": "^0.3.0", | ||
| "gatsby-theme-blog-core": "^1.0.2", | ||
| "gatsby-theme-ui-layout": "^0.3.0", | ||
| "react-helmet": "^5.2.1", | ||
| "theme-ui": "^0.3.1" |
There was a problem hiding this comment.
We should still have theme-ui in dependencies.
It's imported in
And then we don't need core and mdx.
Dependencies could look like this
"dependencies": {
"@emotion/core": "^10.0.0",
"@mdx-js/react": "^1.0.0",
"@theme-ui/preset-base": "^0.4.0-alpha.0",
"gatsby-plugin-react-helmet": "^3.1.3",
"gatsby-plugin-theme-ui": "^0.4.0-alpha.1",
"gatsby-theme-blog-core": "^1.0.2",
"gatsby-theme-ui-layout": "^0.4.0-alpha.0",
"react-helmet": "^5.2.1",
"theme-ui": "^0.4.0-alpha.1"
},
Comment on lines
+1
to
+3
| { | ||
| "extends": "../core/tsconfig" | ||
| } |
There was a problem hiding this comment.
This lands in user's node_modules. I think we can't reference core's tsconfig there.
Suggested change
| { | |
| "extends": "../core/tsconfig" | |
| } | |
| { | |
| "compilerOptions": { | |
| "resolveJsonModule": true, | |
| "esModuleInterop": true, | |
| "moduleResolution": "node", | |
| "strict": true, | |
| "jsx": "preserve" | |
| } | |
| } |
|
Thank you so much for this contribution—unfortunately we’ve deprecated this package :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
gatsby-theme-ui-blogto TypeScript.Related to #668.