Skip to content

Commit

Permalink
soc/intel/meteorlake: Enable USB2 port reset message on Type-C ports
Browse files Browse the repository at this point in the history
Apply commit c6b65c1 ("soc/intel/alderlake: Enable USB2 port reset
message on Type-C ports") to Meteor Lake.

This change is added to address the issue of USB3 ports downgrading to
high speed during low power modes and not returning back to super speed.

The patch enables port reset event on USB2 ports. This event is
is passed to USB3 upstream ports to upgrade back to super speed (USB3)
after a downgrade during low power state.

Change-Id: Iac702a8d8edd2b3b7e03abcac020be7e45335821
Signed-off-by: Jeremy Soller <jeremy@system76.com>
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82730
Reviewed-by: Subrata Banik <subratabanik@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
  • Loading branch information
jackpot51 authored and felixheld committed Jun 3, 2024
1 parent 740cf98 commit 657cef2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/soc/intel/meteorlake/fsp_params.c
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,8 @@ static void fill_fsps_xhci_params(FSP_S_CONFIG *s_cfg,
s_cfg->Usb2OverCurrentPin[i] = config->usb2_ports[i].ocpin;
else
s_cfg->Usb2OverCurrentPin[i] = OC_SKIP;

s_cfg->PortResetMessageEnable[i] = config->usb2_ports[i].type_c;
}

max_port = get_max_usb30_port();
Expand Down
2 changes: 2 additions & 0 deletions src/soc/intel/meteorlake/include/soc/usb.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ struct usb2_port_config {
uint8_t tx_emp_enable;
uint8_t pre_emp_bias;
uint8_t pre_emp_bit;
uint8_t type_c;
};

/* USB Overcurrent pins definition */
Expand Down Expand Up @@ -112,6 +113,7 @@ enum {
.tx_emp_enable = USB2_PRE_EMP_ON, \
.pre_emp_bias = USB2_BIAS_56P3MV, \
.pre_emp_bit = USB2_HALF_BIT_PRE_EMP, \
.type_c = 1, \
}

struct usb3_port_config {
Expand Down

0 comments on commit 657cef2

Please sign in to comment.