pwm: Reload counters when they reach 0 #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crawfxrd
force-pushed
the
pwm-reload
branch
4 times, most recently
from
00a617b
to
217eee5
Compare
Add IT5570E register that controls when the down counters are updated. Set them to update when they reach 0, instead of immediately when DCRi is written. Fixes keyboard color changing when changing brightness levels if not using 0xFF for an RGB value. Signed-off-by: Tim Crawford <tcrawford@system76.com>
jacobgkau
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Recreated #174 on oryp8 and confirmed this PR fixes it. (When using 310086 purple as an example, I do still see a slight shift in hue as I turn the brightness all the way from one side to the other; but the shift is now consistent, rather than jumping around, and it remains somewhat purple rather than jumping between blue and pink.)
13r0ck
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add IT5570E register that controls when the down counters are updated. Set them to update when they reach 0, instead of immediately when DCRi is written.
Fixes keyboard color changing when changing brightness levels if not using 0xFF for an RGB value.
Fixes: #174