Skip to content

Commit

Permalink
Match GUID directly
Browse files Browse the repository at this point in the history
Drop the use of GuidKind and compare GUIDs directly.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
  • Loading branch information
crawfxrd committed Nov 21, 2023
1 parent 97b7b49 commit 5d443c8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
7 changes: 3 additions & 4 deletions src/app/pci.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
use core::{mem, slice};
use hwio::{Io, Pio};
use std::prelude::*;
use std::uefi::guid::GuidKind;
use std::uefi::guid;

#[allow(dead_code)]
#[repr(packed)]
Expand Down Expand Up @@ -82,8 +81,8 @@ unsafe fn rsdp_mcfg(rsdp: &Rsdp) -> Option<&'static [u8]> {

pub fn pci_mcfg() -> Option<&'static [u8]> {
for table in std::system_table().config_tables() {
match table.VendorGuid.kind() {
GuidKind::Acpi | GuidKind::Acpi2 => unsafe {
match table.VendorGuid {
guid::ACPI_TABLE_GUID | guid::ACPI_20_TABLE_GUID => unsafe {
let rsdp = &*(table.VendorTable as *const Rsdp);
if let Some(some) = rsdp_mcfg(rsdp) {
return Some(some);
Expand Down
9 changes: 4 additions & 5 deletions src/dmi.rs
Original file line number Diff line number Diff line change
@@ -1,21 +1,20 @@
// SPDX-License-Identifier: GPL-3.0-only

use core::slice;
use std::prelude::*;
use std::uefi::guid::GuidKind;
use std::uefi::guid;

pub fn dmi() -> Vec<dmi::Table> {
for table in std::system_table().config_tables() {
let data_opt = match table.VendorGuid.kind() {
GuidKind::Smbios => unsafe {
let data_opt = match table.VendorGuid {
guid::SMBIOS_TABLE_GUID => unsafe {
let smbios = &*(table.VendorTable as *const dmi::Smbios);
//TODO: smbios is_valid fails on bonw14, assume UEFI is right
Some(slice::from_raw_parts(
smbios.table_address as *const u8,
smbios.table_length as usize,
))
},
GuidKind::Smbios3 => unsafe {
guid::SMBIOS3_TABLE_GUID => unsafe {
let smbios = &*(table.VendorTable as *const dmi::Smbios3);
//TODO: smbios is_valid fails on bonw14, assume UEFI is right
Some(slice::from_raw_parts(
Expand Down

0 comments on commit 5d443c8

Please sign in to comment.