ec: Assume ROM size is total flash size #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the hard-coded assumption that the EC is always 128K, as ITE chips can also be 256K (which Clevo has started using since addw4). Instead assume the ROM is correctly sized, which we do since system76/ec@0d83819a21f87 ("Pad binary file to total flash size") and proprietary firmware has always done. Signed-off-by: Tim Crawford <tcrawford@system76.com>
jackpot51
approved these changes
Feb 15, 2024
leviport
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the hard-coded assumption that the EC is always 128K, as ITE chips can also be 256K (which Clevo has started using since addw4). Instead assume the ROM is correctly sized, which we do since system76/ec@0d83819a21f87 ("Pad binary file to total flash size") and proprietary firmware has always done.
Ref: #100
Ref: system76/ec#435