Defer unlock prompt until update is accepted #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move unlocking from EC validation to the main app update logic. This allows users to accept updating before unlocking, or cancel without unlocking. This does not resolve the issue of returning to firmware-update when canceling/failing the unlock prompt, as the boot override still exists. Signed-off-by: Tim Crawford <tcrawford@system76.com>
jackpot51
approved these changes
Jun 7, 2023
|
I looked at:
And all three worked as I believe is expected:
I also made sure to test a drive with the wrong firmware, which correctly errors out. That sounds good? |
XV-02
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move unlocking from EC validation to the main app update logic. This allows users to accept updating before unlocking, or cancel without unlocking.
This does not resolve the issue of returning to firmware-update when canceling/failing the unlock prompt, as the boot override still exists.
The UX for this needs additional improvements.
TEST:
Resolves: #81
Partially resolves: system76/firmware-open#405