Add support for ASRock firmware flashing #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackpot51
reviewed
Sep 13, 2023
leviport
force-pushed
the
spark-b1
branch
2 times, most recently
from
b3d36c4
to
a548a0e
Compare
jackpot51
approved these changes
Sep 13, 2023
|
This looks good now, are there any issues using this change to flash spark? |
|
I'm still testing the rest of the flags to see which are necessary, and whether I need to include any others from the docs for that efi tool. I'll mark as ready for review once I'm happy with it. |
|
/P /B /N /L works good. I'm getting an error about DMI being write protected, but DMI values are still set to what we need, so I think it might be safe to ignore |
jackpot51
approved these changes
Sep 13, 2023
|
@leviport Make sure to update the submodule in the firmware PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.