Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of prelude_import #90

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Remove use of prelude_import #90

merged 1 commit into from
Oct 19, 2023

Conversation

crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented Oct 17, 2023

Fixes the following warning:

warning: the feature `prelude_import` is internal to the compiler or standard library
 --> src/main.rs:5:12
  |
5 | #![feature(prelude_import)]
  |            ^^^^^^^^^^^^^^
  |
  = note: using it is strongly discouraged
  = note: `#[warn(internal_features)]` on by default

Resolves: #88

Fixes the following warning:

    warning: the feature `prelude_import` is internal to the compiler or standard library
     --> src/main.rs:5:12
      |
    5 | #![feature(prelude_import)]
      |            ^^^^^^^^^^^^^^
      |
      = note: using it is strongly discouraged
      = note: `#[warn(internal_features)]` on by default

Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd crawfxrd requested review from a team October 17, 2023 17:01
@crawfxrd crawfxrd changed the title Remove use of prelude_import Remove use of prelude_import Oct 17, 2023
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the later instance of this warning (an earlier instance for its use in gop-policy still occurs).

@jackpot51 jackpot51 merged commit 79fe20a into master Oct 19, 2023
2 checks passed
@jackpot51 jackpot51 deleted the rm-prelude-import branch October 19, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove use of prelude_import
3 participants