Reboot on success after flashing all components #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the need for user input in firmware-update when all updates were applied successfully. Signed-off-by: Tim Crawford <tcrawford@system76.com>
jackpot51
approved these changes
Nov 21, 2023
leviport
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
This works, but it only eliminates the "Press any key to reboot" action requirement from the user after a successful firmware update. The two manual power button presses are still necessary before that screen appears. This was expected since the watchdog reset in EC happens, but I wanted to make a note of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the need for user input in firmware-update when all updates were applied successfully.
Test: