Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incremental mode when used without build script #162

Closed

Conversation

poettering
Copy link
Member

A fix for #143. I don't think -i without build script makes sense, but we should handle it gracefully.

… set

There's no reason to cache images unless there's a build script which we
want to speed up the preparation for.

Fixes: systemd#143
…uild script

Let's be helpful to the user, informing him that -i only really makes
sense in build script mode.
@fthiery
Copy link
Contributor

fthiery commented Oct 10, 2017

As said in my original PR, i think there is a valid usecase for -i support without build script: it's producing distribution spins (e.g. pre-customize it with non-standard packages, create users, define locales, ...). You don't build anything but there is a trial-and-error approach that can be improved a lot by supporting caching.

@ghost
Copy link

ghost commented Oct 16, 2017

Yes I wanted to construct my container incrementally, starting simple (since I was also learning mkosi at the same time), and then adding more and more stuff for my needs, but one thing at a time to test if everything works so far. But I stopped using mkosi because the caching didn't work and it was too slow to execute everything each time (installing all the base packages etc, even if the packages are already downloaded).

@keszybz
Copy link
Member

keszybz commented Nov 14, 2017

Replaced by #155.

@keszybz keszybz closed this Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants