Support booting Fedora default image on s390x #2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaanDeMeyer
force-pushed
the
s390
branch
4 times, most recently
from
35d46c4
to
8ae86a7
Compare
behrmann
reviewed
Dec 15, 2023
If building a bootable image is not explicitly disabled and we don't split out an initrd from a UKI because the dependencies are not installed or we're on the wrong architecture, let's still build an initrd so that booting with qemu direct kernel boot still works.
Instead of considering all match sections part of the same match, let's consider each [Match] section on its own. This allows doing multiple independent triggers, such as: """ [Match] Format=|disk Format=|directory [Match] Architecture=|x86-64 Architecture=|arm64 """ Which now means to match if the format is one of disk or directory and the architecture is one of x86-64 or arm64.
If qemu fails to start then virtiofsd won't shut down on its own so let's explicitly send it a signal to shut down.
For testing purposes we might want to override these.
This was referenced Dec 19, 2023
|
@DaanDeMeyer sorry for bothering you in a closed PR, I think this PR is to enable an image on s390x and make it launched via qemu? May I know an example mkosi.conf that worked? |
|
@huoqifeng You should be able to use the mkosi configuration from the mkosi repository itself as an example. If I run "mkosi -d fedora --architecture s390x -f qemu" in the mkosi repository, that will boot with virtiofs into a qemu VM running s390. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.