Use f-strings and some minor cleanups #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I kept or switched to .format in a few places where the arguments were more complicated.
This is useful during development to allow 'import mkosi', for example to test import functions and such. In the future it'll also be useful if we grow any unittests.
poettering
reviewed
Nov 6, 2018
| @@ -193,7 +193,7 @@ def gpt_root_native(arch: str) -> Tuple[uuid.UUID, uuid.UUID]: | |||
| elif arch == 'aarch64': | |||
| return GPTRootTypePair(GPT_ROOT_ARM_64, GPT_ROOT_ARM_64_VERITY) | |||
| else: | |||
There was a problem hiding this comment.
hmm, the python version check at the top of the script should be updated to 3.6 now, right?
|
lgtm but misses the updated python version check |
f-strings are a syntax error with older versions anyway, but let's bump the version string for any human readers.
|
UPdated. |
|
Setup.py is missing (which is probably where distros will look). |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.