Skip to content

Commit

Permalink
core: try to reopen /dev/kmsg again right after mounting /dev
Browse files Browse the repository at this point in the history
I was debugging stuff during early boot, and was confused that I never
found the logs for it in kmsg. The reason for that was that /proc is
generally not mounted the first time we do log_open() and hence
log_set_target(LOG_TARGET_KMSG) we do when running as PID 1 had not
effect. A lot later during start-up we call log_open() again where this
is fixed (after the point where we close all remaining fds still open),
but in the meantime no logs every got written to kmsg. This patch fixes
that.
  • Loading branch information
poettering authored and keszybz committed Jul 24, 2019
1 parent db8d014 commit 0a2eef1
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/core/main.c
Expand Up @@ -2427,6 +2427,11 @@ int main(int argc, char *argv[]) {
goto finish;
}

/* Let's open the log backend a second time, in case the first time didn't
* work. Quite possibly we have mounted /dev just now, so /dev/kmsg became
* available, and it previously wasn't. */
log_open();

r = initialize_security(
&loaded_policy,
&security_start_timestamp,
Expand Down

0 comments on commit 0a2eef1

Please sign in to comment.