sd-journal: refuse to write entry without boot ID

To make journal entries always contain valid boot ID.
systemd · Sep 26, 2023 · 1eede15 · 1eede15
1 parent b761ae0
commit 1eede15
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/libsystemd/sd-journal/journal-file.c b/src/libsystemd/sd-journal/journal-file.c
@@ -2299,6 +2299,7 @@ static int journal_file_append_entry_internal(
         assert(f->header);
         assert(ts);
         assert(boot_id);
+        assert(!sd_id128_is_null(*boot_id));
         assert(items || n_items == 0);
 
         if (f->strict_order) {
@@ -2528,7 +2529,10 @@ int journal_file_append_entry(
                 ts = &_ts;
         }
 
-        if (!boot_id) {
+        if (boot_id) {
+                if (sd_id128_is_null(*boot_id))
+                        return log_debug_errno(SYNTHETIC_ERRNO(EBADMSG), "Empty boot ID, refusing entry.");
+        } else {
                 r = sd_id128_get_boot(&_boot_id);
                 if (r < 0)
                         return r;