Skip to content

Commit

Permalink
network/radv: drop unnecessary conditions
Browse files Browse the repository at this point in the history
sd_radv_set_xyz() will handle invalid values gracefully.
  • Loading branch information
yuwata committed Apr 22, 2024
1 parent c6ffb87 commit a05381d
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions src/network/networkd-radv.c
Original file line number Diff line number Diff line change
Expand Up @@ -542,21 +542,17 @@ static int radv_configure(Link *link) {
if (r < 0)
return r;

if (link->network->router_lifetime_usec > 0) {
r = sd_radv_set_preference(link->radv, link->network->router_preference);
if (r < 0)
return r;
}
r = sd_radv_set_preference(link->radv, link->network->router_preference);
if (r < 0)
return r;

r = sd_radv_set_reachable_time(link->radv, link->network->router_reachable_usec);
if (r < 0)
return r;

if (link->network->router_retransmit_usec > 0) {
r = sd_radv_set_retransmit(link->radv, link->network->router_retransmit_usec);
if (r < 0)
return r;
}
r = sd_radv_set_retransmit(link->radv, link->network->router_retransmit_usec);
if (r < 0)
return r;

HASHMAP_FOREACH(p, link->network->prefixes_by_section) {
r = radv_set_prefix(link, p);
Expand Down

0 comments on commit a05381d

Please sign in to comment.