Skip to content

Commit

Permalink
tmpfiles: downgrade error message when operation is not supported (#5692
Browse files Browse the repository at this point in the history
)

Fixes #5607
  • Loading branch information
yuwata authored and poettering committed Apr 10, 2017
1 parent c9b0610 commit c258349
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/tmpfiles/tmpfiles.c
Original file line number Diff line number Diff line change
Expand Up @@ -973,7 +973,7 @@ static int path_set_attribute(Item *item, const char *path) {

r = chattr_fd(fd, f, item->attribute_mask);
if (r < 0)
log_full_errno(r == -ENOTTY ? LOG_DEBUG : LOG_WARNING,
log_full_errno(r == -ENOTTY || r == -EOPNOTSUPP ? LOG_DEBUG : LOG_WARNING,
r,
"Cannot set file attribute for '%s', value=0x%08x, mask=0x%08x: %m",
path, item->attribute_value, item->attribute_mask);
Expand Down

1 comment on commit c258349

@drydenp
Copy link

@drydenp drydenp commented on c258349 Dec 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So two years ago #560 you made so much fuss over ReiserFS, XFS, NTFS and VFAT (and exfat) to change its behaviour when all it required was this little fix ;-).

In Ubuntu 16.04 the logs are now filled with these messages if you activate a persistent journal. Anyway, not important. But the first version that fixes it is 17.10.

Oh I should add, this results from the upgrade to kernel 4.10 in 16.04.3 of course.

Please sign in to comment.