Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkd bond: expose tlb_dynamic_lb #11135

Closed
carlanton opened this issue Dec 12, 2018 · 4 comments
Closed

networkd bond: expose tlb_dynamic_lb #11135

carlanton opened this issue Dec 12, 2018 · 4 comments
Labels
network RFE 🎁 Request for Enhancement, i.e. a feature request

Comments

@carlanton
Copy link

Is your feature request related to a problem? Please describe.
Currently it's not possible to disable the dynamic shuffling of flows in the network bonding mode balance-tlb. There is an option tlb_dynamic_lb that can be set to zero, but it's not exposed in the networkd configuration.

Describe the solution you'd like
I'd like the following option under the [Bond] section:

TlbDynamicLb=
    A boolean. When false, dynamic shuffling of flows in balance-tlb mode is disabled.

I'm not sure about the naming of the option or if it should be a boolean or not. It may be more future proof to only set the option when it present in conf.

https://www.kernel.org/doc/Documentation/networking/bonding.txt [tlb_dynamic_lb]

@poettering
Copy link
Member

/cc @ssahani

@poettering poettering added RFE 🎁 Request for Enhancement, i.e. a feature request network labels Dec 12, 2018
ssahani added a commit to ssahani/systemd that referenced this issue Dec 13, 2018
ssahani added a commit to ssahani/systemd that referenced this issue Dec 13, 2018
@ssahani
Copy link
Contributor

ssahani commented Dec 13, 2018

@carlanton Please test the PR

@carlanton
Copy link
Author

@ssahani Great! I've tried the patch and it works great. However, it should probably default to true to not break the current behavior for balance-tlb.

ssahani added a commit to ssahani/systemd that referenced this issue Dec 13, 2018
ssahani added a commit to ssahani/systemd that referenced this issue Dec 13, 2018
@ssahani
Copy link
Contributor

ssahani commented Dec 13, 2018

@carlanton just took @yuwata's opinion. Defaults to unset now. thanks for testing the patch. We expect much contributions 👍

ssahani added a commit to ssahani/systemd that referenced this issue Dec 13, 2018
ssahani added a commit to ssahani/systemd that referenced this issue Dec 14, 2018
Closes systemd#11135

Add test for bond : tlb_dynamic_lb
ssahani added a commit to ssahani/systemd that referenced this issue Dec 15, 2018
Closes systemd#11135

Add test for bond : tlb_dynamic_lb
mrc0mmand pushed a commit to mrc0mmand/systemd-rhel that referenced this issue Feb 6, 2019
Closes systemd/systemd#11135

Add test for bond : tlb_dynamic_lb

(cherry picked from commit fde60a4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network RFE 🎁 Request for Enhancement, i.e. a feature request
Development

No branches or pull requests

4 participants