New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Units which fail Conditions hit restart limit and fail #13434
Comments
Apparently this is not a (recent) regression. I get the same result with v242. I think we should ignore start limits for units which fail conditions. Anything else makes little sense. |
Possibly related this downstream bug report https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=935829 which says that it's a regression in v242 |
Yep, v241-stable doesn't exhibit the bug. I'm bisecting it now. |
This reverts commit 2de9b97. This check causes regressions, in particular our own units fail. Apparently, it is enough for the unit to be referenced enough times: $ journalctl -b -u systemd-ask-password-console.path Aug 30 12:08:14 krowka systemd[1]: Condition check resulted in Dispatch Password Requests to Console Directory Watch being skipped. Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in Dispatch Password Requests to Console Directory Watch being skipped. Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in Dispatch Password Requests to Console Directory Watch being skipped. Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in Dispatch Password Requests to Console Directory Watch being skipped. Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in Dispatch Password Requests to Console Directory Watch being skipped. Aug 30 12:08:33 krowka systemd[1]: systemd-ask-password-console.path: Start request repeated too quickly. Aug 30 12:08:33 krowka systemd[1]: Failed to start Dispatch Password Requests to Console Directory Watch. $ journalctl -b -u systemd-firstboot.service -- Logs begin at Sun 2019-04-21 12:39:21 CEST, end at Fri 2019-08-30 12:23:06 CEST. -- Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in First Boot Wizard being skipped. Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in First Boot Wizard being skipped. Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in First Boot Wizard being skipped. Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in First Boot Wizard being skipped. Aug 30 12:08:33 krowka systemd[1]: systemd-firstboot.service: Start request repeated too quickly. Aug 30 12:08:33 krowka systemd[1]: Failed to start First Boot Wizard. And the same for other units. Fixes systemd#13434. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=935829
This reverts commit 2de9b97. This check causes regressions, in particular our own units fail. Apparently, it is enough for the unit to be referenced enough times: $ journalctl -b -u systemd-ask-password-console.path Aug 30 12:08:14 krowka systemd[1]: Condition check resulted in Dispatch Password Requests to Console Directory Watch being skipped. Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in Dispatch Password Requests to Console Directory Watch being skipped. Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in Dispatch Password Requests to Console Directory Watch being skipped. Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in Dispatch Password Requests to Console Directory Watch being skipped. Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in Dispatch Password Requests to Console Directory Watch being skipped. Aug 30 12:08:33 krowka systemd[1]: systemd-ask-password-console.path: Start request repeated too quickly. Aug 30 12:08:33 krowka systemd[1]: Failed to start Dispatch Password Requests to Console Directory Watch. $ journalctl -b -u systemd-firstboot.service -- Logs begin at Sun 2019-04-21 12:39:21 CEST, end at Fri 2019-08-30 12:23:06 CEST. -- Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in First Boot Wizard being skipped. Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in First Boot Wizard being skipped. Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in First Boot Wizard being skipped. Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in First Boot Wizard being skipped. Aug 30 12:08:33 krowka systemd[1]: systemd-firstboot.service: Start request repeated too quickly. Aug 30 12:08:33 krowka systemd[1]: Failed to start First Boot Wizard. And the same for other units. Fixes systemd#13434. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=935829 (cherry picked from commit 5af6aa5)
Latest git (243-rc2-14-gca5077f).
The text was updated successfully, but these errors were encountered: