Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build on arm64 #14031

Closed
mbiebl opened this issue Nov 14, 2019 · 4 comments · Fixed by #14032
Closed

Fails to build on arm64 #14031

mbiebl opened this issue Nov 14, 2019 · 4 comments · Fixed by #14032
Labels
bug 🐛 Programming errors, that need preferential fixing seccomp

Comments

@mbiebl
Copy link
Contributor

mbiebl commented Nov 14, 2019

v243 fails to build on arm64 on Debian sid:


../src/test/test-seccomp.c: In function ‘test_protect_sysctl’:
../src/test/test-seccomp.c:307:5: error: "__NR__sysctl" is not defined, evaluates to 0 [-Werror=undef]
  307 | #if __NR__sysctl > 0
      |     ^~~~~~~~~~~~
../src/test/test-seccomp.c:314:5: error: "__NR__sysctl" is not defined, evaluates to 0 [-Werror=undef]
  314 | #if __NR__sysctl > 0
      |     ^~~~~~~~~~~~
cc1: some warnings being treated as errors

Full build log available at https://buildd.debian.org/status/fetch.php?pkg=systemd&arch=arm64&ver=243-6&stamp=1573744894&raw=0

I'm not entirely sure what changed between 243-5 and 243-6 which could trigger that error.
243-5 built fine https://buildd.debian.org/status/fetch.php?pkg=systemd&arch=arm64&ver=243-6&stamp=1573744894&raw=0

@poettering
Copy link
Member

is it possible that not systemd changed but libseccomp? old libseccomp used to define __NR_sysctl and friends to negative values on systems that do not support them. The newest libseccomp doesn#t do that anymore. Maybe libseccomp was updated like that on debian at the same time?

@mbiebl
Copy link
Contributor Author

mbiebl commented Nov 14, 2019

Good call, libseccomp was updated between 243-5 and 243-6:

https://tracker.debian.org/news/1079515/accepted-libseccomp-242-1-source-into-unstable/

Seems like 2.4.2-1 does trigger this build failure.

@poettering poettering added bug 🐛 Programming errors, that need preferential fixing seccomp labels Nov 14, 2019
poettering added a commit to poettering/systemd that referenced this issue Nov 14, 2019
…namespace invasion

A follow-up for 59b6572, adding the
same conditioning for all cases of our __NR_xyz use.

Fixes: systemd#14031
@poettering
Copy link
Member

Can you check if #14032 fixes this for you?

@mbiebl
Copy link
Contributor Author

mbiebl commented Nov 14, 2019

The above PR does fix the build failure on arm64.

keszybz pushed a commit that referenced this issue Nov 15, 2019
…namespace invasion

A follow-up for 59b6572, adding the
same conditioning for all cases of our __NR_xyz use.

Fixes: #14031
jackpot51 pushed a commit to pop-os/systemd that referenced this issue Jan 25, 2020
flokli pushed a commit to flokli/systemd that referenced this issue Feb 18, 2020
…namespace invasion

A follow-up for 59b6572, adding the
same conditioning for all cases of our __NR_xyz use.

Fixes: systemd#14031
(cherry picked from commit 4df8fe8)
mikhailnov pushed a commit to mikhailnov/systemd that referenced this issue Mar 12, 2020
…namespace invasion

A follow-up for 59b6572, adding the
same conditioning for all cases of our __NR_xyz use.

Fixes: systemd#14031
mikhailnov pushed a commit to mikhailnov/systemd that referenced this issue Aug 10, 2021
…namespace invasion

A follow-up for 59b6572, adding the
same conditioning for all cases of our __NR_xyz use.

Fixes: systemd#14031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Programming errors, that need preferential fixing seccomp
Development

Successfully merging a pull request may close this issue.

2 participants