Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add passwdqc support to systemd-homed #15055

Closed
shaba opened this issue Mar 9, 2020 · 12 comments · Fixed by #20425
Closed

add passwdqc support to systemd-homed #15055

shaba opened this issue Mar 9, 2020 · 12 comments · Fixed by #20425
Labels
homed homed, homectl, pam_homed needs-patch RFE 🎁 Request for Enhancement, i.e. a feature request

Comments

@shaba
Copy link
Contributor

shaba commented Mar 9, 2020

Please, add passwdqc (https://www.openwall.com/passwdqc/) support as option like pwquality.
LUKS can build with passwdqc support.

@anitazha anitazha added homed homed, homectl, pam_homed RFE 🎁 Request for Enhancement, i.e. a feature request labels Mar 10, 2020
@poettering
Copy link
Member

hmm, are there any distros that make use of that? why is this preferable over libpwquality?

@shaba
Copy link
Contributor Author

shaba commented Mar 31, 2020

ALT Linux used passwdqc since 2001 (https://packages.altlinux.org/en/sisyphus/srpms/passwdqc/changelogs)
@ldv-alt can better explain the reason for using passwdqc.

@poettering
Copy link
Member

Is that the only distro? Why not switch over to libpwquality?

I mean, I am not to keen on supporting a myriad of options there, in particular if it's not something used in big mainstream distros.

@bonktree
Copy link
Contributor

A lot of popular distros include passwdqc and its corresponding PAM module as an option for password quality checking: Debian/Ubuntu, SuSE. Debian in particular offers packages for both and offers neither in its default installation.
As homed in particular and systemd as a whole are actively used over there, it's important for us to be diverse in this regard.

@poettering
Copy link
Member

including is one thing. what about enabling it by default? that's mostly what i care about. fedora/rh based distros all enable libpwquality by default.

@ldv-alt
Copy link
Contributor

ldv-alt commented Mar 31, 2020 via email

@ldv-alt
Copy link
Contributor

ldv-alt commented Mar 31, 2020 via email

@ldv-alt
Copy link
Contributor

ldv-alt commented Mar 31, 2020 via email

@Zlogene
Copy link

Zlogene commented Jul 15, 2020

@poettering in gentoo we also prefer passwdqc over pwquality by default), pretty much for the reason @ldv-alt mentioned.

@poettering
Copy link
Member

hmm, the way i read it noone posted any reason here besides "i like apples better than bananas"... "better", "faster", "smaller" is so vague it couldn't be anymore vague...

But anyway, if you care about this, send a PR (ideally done via dlopen(), as in #16260 or #16145)

@solardiz
Copy link

@poettering I agree the tweets of mine that @ldv-alt referenced are not convincing on their own. Please refer to this third-party comparison of 5 tools, including passwdqc and pwquality:

https://www.slideshare.net/antondedov5/zn2013-testing-of-password-policy-abridged

Slide 23 shows passwdqc miss the fewest weak passwords (crackable in that study's specific attacks), at 0.5%, and pwquality miss the most of those, at over 2%, with the remaining 3 tools staying inbetween.

Slide 25 shows passwdqc and pwquality being equally willing to accept typical not-too-weak passwords that users want to use.

Slides 26 and 27 show pwquality unnecessarily reject most strong passwords that were left uncracked in the Crack Me If You Can 2010 contest (pwquality accepts only 10% of those; passwdqc accepts 60%). They also show pwquality unnecessarily reject almost 20% of randomly-generated 10-character passwords, whereas passwdqc accepts all of those.

Slide 32 shows that pwquality is the slowest of the 5 tools compared, being 13x slower than passwdqc.

There are also some results from the same author at:

http://password-policy-testing.wikidot.com/results

@solardiz
Copy link

Correction: the slide 23 percentage figures quoted above are on a weird scale of up to 300% (since percentages for 3 password sets were added together rather than averaged), so the actual ones would be 3x lower - thus, ~0.17% vs. ~0.7%.

The 4x ratio between the two tools holds regardless of scale. So it can be said that with the tested settings pwquality results in 4x more crackable passwords while not being friendlier in terms of accepting desirable strong-enough passwords.

ldv-alt added a commit to Blarse/systemd that referenced this issue Jul 4, 2023
Co-authored-by: Dmitry V. Levin <ldv@altlinux.org>
Resolves: systemd#15055
ldv-alt added a commit to Blarse/systemd that referenced this issue Jul 6, 2023
Co-authored-by: Dmitry V. Levin <ldv@altlinux.org>
Resolves: systemd#15055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
homed homed, homectl, pam_homed needs-patch RFE 🎁 Request for Enhancement, i.e. a feature request
Development

Successfully merging a pull request may close this issue.

7 participants