Apparent ABI change following 4a56315a990b path: use ROOTPREFIX properly

[akiernan]

systemd version the issue has been seen with

v246

Used distribution

Yocto Poky

Expected behaviour you didn't see

sysusers_dir, sysctl_dir, binfmt_dir, modules_load_dir reference directories in /usr/lib

Unexpected behaviour you saw

sysusers_dir, sysctl_dir, binfmt_dir, modules_load_dir reference directories in /lib - this appears to be a change in the ABI from v245 when split-usr is enabled

Steps to reproduce the problem

Build with split-usr enabled, the paths are then:

root@qemux86-64:~# systemd-path sysusers sysctl modules-load
//lib/sysusers.d
//lib/sysctl.d
//lib/modules-load.d

This appears to be a result of 4a56315 path: use ROOTPREFIX properly

Full configuration:

Message: systemd 246
         split /usr:                        true
         split bin-sbin:                    true
         prefix directory:                  /usr
         rootprefix directory:              /
         sysconf directory:                 /etc
         include directory:                 /usr/include
         lib directory:                     /usr/lib
         rootlib directory:                 /lib
         SysV init scripts:                 /etc/init.d
         SysV rc?.d directories:            /etc
         PAM modules directory:             /lib/security
         PAM configuration directory:       /etc/pam.d
         RPM macros directory:              /usr/lib/rpm/macros.d
         modprobe.d directory:              /lib/modprobe.d
         D-Bus policy directory:            /usr/share/dbus-1/system.d
         D-Bus session directory:           /usr/share/dbus-1/services
         D-Bus system directory:            /usr/share/dbus-1/system-services
         bash completions directory:        /usr/share/bash-completion/completions
         zsh completions directory:         /usr/share/zsh/site-functions
         extra start script:                /etc/rc.local
         debug shell:                       /bin/sh @ /dev/tty9
         TTY GID:                           5
         users GID:                         -
         maximum system UID:                999
         maximum system GID:                999
         minimum dynamic UID:               61184
         maximum dynamic UID:               65519
         minimum container UID base:        524288
         maximum container UID base:        1878982656
         /dev/kvm access mode:              0666
         render group access mode:          0666
         certificate root directory:        /etc/ssl
         support URL:                       https://lists.freedesktop.org/mailman/listinfo/systemd-devel
         nobody user name:                  nobody
         nobody group name:                 nobody
         fallback hostname:                 localhost
         symbolic gateway hostnames:        _gateway
         default DNSSEC mode:               no
         default DNS-over-TLS mode:         no
         default mDNS mode:                 yes
         default LLMNR mode:                yes
         default cgroup hierarchy:          hybrid
         default net.naming-scheme setting: latest
         default KillUserProcesses setting: true
         default locale:                    C
         default user $PATH:                (same as system services)
         systemd service watchdog:          3min
         default DNS servers:               1.1.1.1
                                            8.8.8.8
                                            1.0.0.1
                                            8.8.4.4
                                            2606:4700:4700::1111
                                            2001:4860:4860::8888
                                            2606:4700:4700::1001
                                            2001:4860:4860::8844
         default NTP servers:               time1.google.com
                                            time2.google.com
                                            time3.google.com
                                            time4.google.com
         time epoch:                        1596812993 (2020-08-07T15:09:53+00:00)
         static libsystemd:                 false
         static libudev:                    false

         enabled features: libfdisk, IMA, xz, ACL, idn, initrd, binfmt, vconsole, quotacheck, tmpfiles, environment.d, sysusers, randomseed, backlight, rfkill, xdg-autostart, logind, machined, userdb, hostnamed, timedated, timesyncd, localed, networkd, resolve, pstore, kmod, xkbcommon, blkid, nss-myhostname, nss-mymachines, nss-resolve, nss-systemd, hwdb, tpm, SysV compat, utmp, ldconfig, hibernate, adm group, wheel group, gshadow, link-systemctl-shared, link-networkd-shared, link-timesyncd-shared, kernel-install, systemd-analyze

         disabled features: libcryptsetup, PAM, pwquality, p11kit, libfido2, AUDIT, AppArmor, SELinux, SECCOMP, SMACK, zlib, zstd, lz4, bzip2, gcrypt, qrencode, microhttpd, gnutls, openssl, libcurl, libidn2, libidn, libiptc, elfutils, repart, firstboot, portabled, homed, importd, DNS-over-TLS(gnutls), DNS-over-TLS(openssl), coredump, polkit, legacy pkla, efi, gnu-efi, pcre2, dbus, glib, man pages, html pages, man page indices, debug hashmap, debug mmap cache, debug siphash, valgrind, trace logging, install tests, link-udev-shared

[poettering]

christ, this is terrible...

[shr-project]

@poettering Isn't there still inconsistency in modules-load.d directory?

Since this "4a56315a990b path: use ROOTPREFIX properly" commit systemd.pc uses rootprefix instead of prefix:
-modules_load_dir=${prefix}/lib/modules-load.d
+modules_load_dir=${rootprefix}/lib/modules-load.d

but meson.build still uses prefixdir:
modulesloaddir = join_paths(prefixdir, 'lib/modules-load.d')