Add missing desktop entry keys to XDG autostart generator #17276
Labels
Comments
|
Maybe those log messages could be downgraded to debug (at least some of them). |
|
Looking at that, I agree that most of the messages should be downgraded from info to debug, they don't seem to be of much use except to someone debugging a desktop entry that's not starting correctly.
I still feel the four desktop entry keys I mentioned should probably be added to the array of desktop entries I mentioned earlier as they are part of the official desktop entry standard and not really unknown.
…On Wed, Oct 7, 2020, at 7:24 PM, Michael Biebl wrote:
Maybe those log messages could be downgraded to debug (at least some of them).
Slightly related is this downstream bug report https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=968116
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#17276 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJEW2XG6RXECUZZ7KUHWCADSJT2CDANCNFSM4SHV6WNA>.
|
|
Yeah, we should downgade the messages at least for standard defined, but ignored keys. /cc @benzea |
benzea
pushed a commit
to benzea/systemd
that referenced
this issue
Oct 8, 2020
It makes sense to ignore all the common fields that are expected and that we can safely ignore. Note that it is fine to ignore URL as we will already warn about the type= being wrong in that case. Closes: systemd#17276
benzea
pushed a commit
to benzea/systemd
that referenced
this issue
Oct 8, 2020
It makes sense to ignore all the common fields that are expected and that we can safely ignore. Note that it is fine to ignore URL as we will already warn about the type= being wrong in that case. Closes: systemd#17276
benzea
pushed a commit
to benzea/systemd
that referenced
this issue
Oct 8, 2020
It makes sense to ignore all the common fields that are expected and that we can safely ignore. Note that it is fine to ignore URL as we will already warn about the type= being wrong in that case. Closes: systemd#17276
lqb
pushed a commit
to lqb/systemd
that referenced
this issue
Oct 29, 2020
It makes sense to ignore all the common fields that are expected and that we can safely ignore. Note that it is fine to ignore URL as we will already warn about the type= being wrong in that case. Closes: systemd#17276
mikhailnov
pushed a commit
to mikhailnov/systemd
that referenced
this issue
Jan 16, 2021
It makes sense to ignore all the common fields that are expected and that we can safely ignore. Note that it is fine to ignore URL as we will already warn about the type= being wrong in that case. Closes: systemd#17276 (cherry picked from commit 51ac77d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Currently whenever I login I get a spew of log spam related to .desktop files and unknown keys from auto-start applications. Notably Path, MimeType, StartupWMClass, and URL are considered unknown keys, however each are standard keys per the Desktop Entry Specification and are not listed in
xdg-autostart-service.cwith the rest of the standard keys.Here's an anonymized example from my logs:
I don't have an example of the URL key being logged as unknown, but it appears to be missing in the code related to auto starting applications.
Describe the solution you'd like
Ideally each missing key would be added and would not be logged every time I login as a direct result.
Describe alternatives you've considered
I suppose they could just not be added and I can live with 5-8 lines of unnecessary log spam.
The text was updated successfully, but these errors were encountered: