-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent CI tests failures #19903
Comments
Various bionic-* tests are affected. I tried to figure out when this happens for the first time, and #19882 was certainly affected. But I don't see how it could be related to the failure. It seems that something changed on the distro side instead. |
Closed
keszybz
added a commit
to keszybz/systemd
that referenced
this issue
Jun 12, 2021
This reverts commit cc815b7. We don't know quite know why, but this is one of the pull requests implicated in the failures. Fixes systemd#19903.
#19900 passes all upstream tests twice. So, the candidates are
|
yuwata
added a commit
to yuwata/systemd
that referenced
this issue
Jun 14, 2021
Before 81107b8, the compare functions for the latest or earliest prioq did not handle ratelimited flag. So, it was ok to put event source to the prioq before the ratelimited flag. But now, those two compare functions also compare the source is ratelimited or not. So, it is necessary to set ratelimited flag before putting the event source to the prioq. Hopefully fixes systemd#19903.
yuwata
added a commit
to yuwata/systemd
that referenced
this issue
Jun 14, 2021
Before 81107b8, the compare functions for the latest or earliest prioq did not handle ratelimited flag. So, it was ok to put event source to the prioq before the ratelimited flag. But now, those two compare functions also compare the source is ratelimited or not. So, it is necessary to set ratelimited flag before putting the event source to the prioq. Hopefully fixes systemd#19903.
yuwata
added a commit
to yuwata/systemd
that referenced
this issue
Jun 14, 2021
Before 81107b8, the compare functions for the latest or earliest prioq did not handle ratelimited flag. So, it was ok to not reshuffle the time prioq when changing the flag. But now, those two compare functions also compare the source is ratelimited or not. So, it is necessary to reshuffle the time prioq after changing the ratelimited flag. Hopefully fixes systemd#19903.
yuwata
added a commit
to yuwata/systemd
that referenced
this issue
Jun 14, 2021
Before 81107b8, the compare functions for the latest or earliest prioq did not handle ratelimited flag. So, it was ok to not reshuffle the time prioq when changing the flag. But now, those two compare functions also compare the source is ratelimited or not. So, it is necessary to reshuffle the time prioq after changing the ratelimited flag. Hopefully fixes systemd#19903.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: