Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent CI tests failures #19903

Closed
keszybz opened this issue Jun 12, 2021 · 3 comments · Fixed by #19924
Closed

Recent CI tests failures #19903

keszybz opened this issue Jun 12, 2021 · 3 comments · Fixed by #19924
Labels
bug 🐛 Programming errors, that need preferential fixing
Milestone

Comments

@keszybz
Copy link
Member

keszybz commented Jun 12, 2021

--x-- Running TEST-42-EXECSTOPPOST --x--
make: Entering directory '/tmp/autopkgtest.ZCr9be/build.piX/systemd/test/TEST-42-EXECSTOPPOST'
TEST-42-EXECSTOPPOST SETUP: test that ExecStopPost= is always run
Reusing existing cached image /tmp/autopkgtest.ZCr9be/build.piX/systemd/build-deb/test/TEST-42-EXECSTOPPOST/../default.img → /tmp/autopkgtest.ZCr9be/build.piX/systemd/build-deb/test/default.img
'/var/tmp/systemd-test.JmxCFD/default.img' -> '/tmp/autopkgtest.ZCr9be/build.piX/systemd/build-deb/test/default.img'
TEST-42-EXECSTOPPOST RUN: test that ExecStopPost= is always run
+ env --unset=UNIFIED_CGROUP_HIERARCHY --unset=SYSTEMD_NSPAWN_UNIFIED_HIERARCHY /tmp/autopkgtest.ZCr9be/build.piX/systemd/build-deb/systemd-nspawn --register=no --kill-signal=SIGKILL --directory=/var/tmp/systemd-test.JmxCFD/root --setenv=SYSTEMD_UNIT_PATH=/usr/lib/systemd/tests/testdata/testsuite-42.units:/usr/lib/systemd/tests/testdata/units: /lib/systemd/systemd systemd.unit=testsuite.target systemd.wants=testsuite-42.service systemd.wants=end.service
Spawning container root on /var/tmp/systemd-test.JmxCFD/root.
Press ^] three times within 1s to kill container.
Failed to allocate scope: Failed to activate service 'org.freedesktop.systemd1': timed out (service_start_timeout=25000ms)
E: nspawn failed with exit code 1
Spawning getter /tmp/autopkgtest.ZCr9be/build.piX/systemd/build-deb/journalctl -o export -D /var/tmp/systemd-test.JmxCFD/root/var/log/journal/*...
Failed to open /var/tmp/systemd-test.JmxCFD/root/var/log/journal/*: No such file or directory
Finishing after writing 0 entries
Failed to open /var/tmp/systemd-test.JmxCFD/root/var/log/journal/*: No such file or directory
rm: cannot remove '/var/tmp/systemd-test.JmxCFD/root/var/log/journal/*': No such file or directory---- /var/tmp/systemd-test.JmxCFD/root/var/log/journal/* ----

TEST-42-EXECSTOPPOST: (failed; see logs)
@keszybz keszybz pinned this issue Jun 12, 2021
@keszybz
Copy link
Member Author

keszybz commented Jun 12, 2021

Various bionic-* tests are affected. I tried to figure out when this happens for the first time, and #19882 was certainly affected. But I don't see how it could be related to the failure. It seems that something changed on the distro side instead.

@keszybz keszybz linked a pull request Jun 12, 2021 that will close this issue
keszybz added a commit to keszybz/systemd that referenced this issue Jun 12, 2021
This reverts commit cc815b7.

We don't know quite know why, but this is one of the pull requests implicated
in the failures. Fixes systemd#19903.
@yuwata yuwata added the bug 🐛 Programming errors, that need preferential fixing label Jun 14, 2021
@yuwata yuwata added this to the v249 milestone Jun 14, 2021
yuwata added a commit to yuwata/systemd that referenced this issue Jun 14, 2021
Before 81107b8, the compare functions
for the latest or earliest prioq did not handle ratelimited flag.
So, it was ok to put event source to the prioq before the ratelimited
flag.
But now, those two compare functions also compare the source is
ratelimited or not. So, it is necessary to set ratelimited flag before
putting the event source to the prioq.

Hopefully fixes systemd#19903.
yuwata added a commit to yuwata/systemd that referenced this issue Jun 14, 2021
Before 81107b8, the compare functions
for the latest or earliest prioq did not handle ratelimited flag.
So, it was ok to put event source to the prioq before the ratelimited
flag.
But now, those two compare functions also compare the source is
ratelimited or not. So, it is necessary to set ratelimited flag before
putting the event source to the prioq.

Hopefully fixes systemd#19903.
yuwata added a commit to yuwata/systemd that referenced this issue Jun 14, 2021
Before 81107b8, the compare functions
for the latest or earliest prioq did not handle ratelimited flag.
So, it was ok to not reshuffle the time prioq when changing the flag.

But now, those two compare functions also compare the source is
ratelimited or not. So, it is necessary to reshuffle the time prioq
after changing the ratelimited flag.

Hopefully fixes systemd#19903.
yuwata added a commit to yuwata/systemd that referenced this issue Jun 14, 2021
Before 81107b8, the compare functions
for the latest or earliest prioq did not handle ratelimited flag.
So, it was ok to not reshuffle the time prioq when changing the flag.

But now, those two compare functions also compare the source is
ratelimited or not. So, it is necessary to reshuffle the time prioq
after changing the ratelimited flag.

Hopefully fixes systemd#19903.
@yuwata yuwata unpinned this issue Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Programming errors, that need preferential fixing
2 participants