-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST-64-UDEV-STORAGE intermittent fails tracker #21819
Comments
@yuwata I managed to weed out a couple of races thanks to the debug logging, but this one boggles my mind:
The last line is from systemd/test/units/testsuite-64.sh Lines 35 to 40 in d874a13
udevadm claims the device doesn't exist?
Full log (CentOS 8): system.journal.tar.gz Recent hit: 2021-11-25 (https://jenkins-systemd.apps.ocp.ci.centos.org/job/upstream-centos8/4688/artifact//systemd-centos-ci/index.html) |
Another intermittent fail, this time spotted a couple of times on Arch:
Full log (Arch Linux): system.journal.tar.gz Recent hit: 2022-01-10 (https://jenkins-systemd.apps.ocp.ci.centos.org/job/upstream-vagrant-archlinux/9438/artifact//systemd-centos-ci/index.html) |
Looking at the second issue (btrfs related), there's a common denominator:
In all failed runs I've seen so far there always was the "floppy0" error after
I'm inclined to drop the @yuwata any thoughts? |
@mrc0mmand Sorry for late response. For the second issue (btrfs), it seems |
Fixes the second issue in systemd#21819.
Is the file broken?? I cannot open it with |
hmm, interesting. Let me look into that. |
Not sure what happened but that journal is indeed corrupted. Thankfully, I managed to find another one with the same issue: system.journal.tar.gz |
Ouch, the btrfs related issue is not fully fixed. |
It seems
|
For debugging issue systemd#21819.
Yeah, TEST-64 seems to be now angrier than usual, probably sensing we're trying to silence it. Is there anything I could do to obtain some useful data for further debugging? |
I have not checked the rate of failure in the test, but if it increased, then I hope we are now closer to investigate the root cause of the issue :-p Now, I am suspecting the behavior of blkid. Does it correctly detect btrfs filesystem even if btrfs module is not loaded yet? As you may observed, some (not sure if all) failure logs show that udev's blkid builtin command is triggered before btrfs kernel module is loaded. cc @karelzak |
For debugging issue systemd#21819.
libblkid works without any interaction with kernel modules; it looks up for magic strings at the block device, so all it needs from kernel is seek() and read() :-) |
This reverts commit 95e3551.
As stated in systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: systemd#21819
This reverts commit 95e3551.
As stated in systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: systemd#21819
This reverts commit 95e3551.
As stated in systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: systemd#21819
This reverts commit 95e3551.
As stated in systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: systemd#21819
This reverts commit 95e3551.
As stated in systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: systemd#21819
This reverts commit 95e3551.
As stated in systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: systemd#21819
This reverts commit 95e3551.
As stated in systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: systemd#21819
This reverts commit 95e3551.
As stated in systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: systemd#21819
This reverts commit 95e3551.
As stated in systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: systemd#21819
As stated in systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: systemd#21819
This reverts commit 95e3551.
As stated in systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: systemd#21819
As stated in systemd/systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: #21819 (cherry picked from commit 41d1aae) Related: #2087652
As stated in systemd/systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: #21819 (cherry picked from commit 41d1aae) Related: #2087652
As stated in systemd/systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: #21819 (cherry picked from commit 41d1aae) Related: #2087652
As stated in systemd/systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: #21819 (cherry picked from commit 41d1aae)
As stated in systemd/systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: #21819 (cherry picked from commit 41d1aae) Related: #2087652
As stated in systemd/systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: #21819 (cherry picked from commit 41d1aae) Related: #2087652
As stated in systemd/systemd#21819 (comment) `mkfs.btrfs` doesn't hold the lock for the whole duration of `mkfs.btrfs`, thus causing unexpected races & test fails. Let's wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this. Hopefully fixes: #21819 (cherry picked from commit 41d1aae) Related: #2087652
(udevadm) Unknown device "XXX": No such device
Unknown device "/dev/disk/by-id/scsi-360000000000000000e00000000020004": No such device
Full journal: system.journal.tar.gz
Unknown device "/dev/disk/by-id/wwn-0x60000000000000000e00000000020003": No such device
Full journal: system.journal.tar.gz
Unknown device "/dev/disk/by-id/wwn-0x60000000000000000e00000000010003": No such device
Full journal: system.journal.tar.gz
The text was updated successfully, but these errors were encountered: