resolve: llmnr: why dns_stream_unref() called in on_llmnr_stream_packet()?? #22266
Comments
yuwata
added a commit
to yuwata/systemd
that referenced
this issue
Jan 28, 2022
Previously, the condition in on_stream_io_impl() never hit, as the read packet is always taken from the stream in the few lines above. Instead of the dns_stream_complete() under the condition, the stream is unref()ed in the on_packet callback for LLMNR stream, unlike the other on_packet callbacks. That's quite tricky. Also, potentially, the stream may still have queued packets to write. This fix the condition, and drops the unref() in the on_packet callback. C.f. systemd#22274 (comment). Closes systemd#22266.
bluca
pushed a commit
to bluca/systemd
that referenced
this issue
Apr 28, 2022
Previously, the condition in on_stream_io_impl() never hit, as the read packet is always taken from the stream in the few lines above. Instead of the dns_stream_complete() under the condition, the stream is unref()ed in the on_packet callback for LLMNR stream, unlike the other on_packet callbacks. That's quite tricky. Also, potentially, the stream may still have queued packets to write. This fix the condition, and drops the unref() in the on_packet callback. C.f. systemd#22274 (comment). Closes systemd#22266. (cherry picked from commit a5e2a48)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
LLMNR stream does not have
completecallback, that means the stream is unref()ed whendns_stream_complete()is called.However, unlike the other
on_packetcallbacks,on_llmnr_stream_packet()unref() the stream.In
on_stream_io(),on_packetis called and thendns_stream_complete()is called. Does this mean the stream is doubly unref()ed?Also, I cannot understand the comment added by 31f2a5e.
The text was updated successfully, but these errors were encountered: