Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[warning] Unexpected final line in man document SYSTEMD-HWDB(8) #23184

Open
mattia-b89 opened this issue Apr 24, 2022 · 6 comments
Open

[warning] Unexpected final line in man document SYSTEMD-HWDB(8) #23184

mattia-b89 opened this issue Apr 24, 2022 · 6 comments

Comments

@mattia-b89
Copy link

This is a very low issue.
When I open man page of systemd-hwdb with GNOME's yelp,
journalctl reports this:

Apr 24 10:24:20 arch-xps yelp[8504]: Unexpected final line in man document (systemd 250                                                    SYSTEMD-HWDB(8))

NB: you can open the man document directly after $ systemd-hwdb --help or using direct command $ yelp "man:systemd-hwdb(8)"


  • Arch Linux
  • systemd-250.4-2
@mrc0mmand
Copy link
Member

This seems to be caused by yelp expecting the last line to be in a format of <version> <date> <man_ref> and the systemd man pages don't have the date part, see https://gitlab.gnome.org/GNOME/yelp/-/blob/master/libyelp/yelp-man-parser.c#L1214-1222.

That makes me wonder - why we skip the date part when generating systemd-related man pages?

@mattia-b89
Copy link
Author

mattia-b89 commented Apr 24, 2022 via email

@mrc0mmand
Copy link
Member

To make it reproducible?

That would certainly make sense, but it should be resolvable by using $SOURCE_DATE_EPOCH.

@mattia-b89
Copy link
Author

mattia-b89 commented Apr 24, 2022

I do not know how this variable works... (I am not an expert of repro-builds...)
Anyway, let's see if it is the problem appears in other distros too, since Arch Linux does not look like to alter man files after compilation.
Here [https://github.com/archlinux/svntogit-packages/blob/packages/systemd/trunk/PKGBUILD] is the PKGBUILD file.

@poettering
Copy link
Member

I think the date at the bottom of the man pages is pretty useless. But if somebody preps a patch to insert $SOURCE_DATE_EPOCH there I'd be fine. Might make sense to make gnome's yelp deal with this natively however.

@poettering
Copy link
Member

I think it would be nicer if yelp would just be able to handle man pages like this. Hence I filed:

https://gitlab.gnome.org/GNOME/yelp/-/issues/216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants