Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkctl reload with bond devices causes slaves to go DOWN and UP, causung few seconds of network loss #25067

Closed
Garagoth opened this issue Oct 19, 2022 · 1 comment · Fixed by #25162
Closed

networkctl reload with bond devices causes slaves to go DOWN and UP, causung few seconds of network loss #25067

Garagoth opened this issue Oct 19, 2022 · 1 comment · Fixed by #25162
Labels
bug 🐛 Programming errors, that need preferential fixing network

Comments

@Garagoth
Copy link

systemd version the issue has been seen with

249 (249.11-0ubuntu3.6)

Used distribution

Ubuntu 22.04.1 LTS

Linux kernel version used

5.15.0-52-generic

CPU architectures issue was seen on

x86_64

Component

networkctl, systemd-networkd

Expected behaviour you didn't see

Network is not iterrupted

Unexpected behaviour you saw

After netplan generate creates config files (when their contents do not change, just timestamps get updated) for networkd - or simply by doing touch /run/systemd/network/*, running networkctl reload always causes network loss by bringing down and up all bond slave interfaces.

Does not happen when bond is not present.
Seems very similar to already closed in 2018 issue: #10118

Steps to reproduce the problem

Create network config with one ethernet and one bond interace on it. Assign IP to bond interface.
Configure network, make sure it works.
Then:
touch /run/systemd/network/*
networkctl reload
Observe network loss and DOWN messages in journalctl -xe:

Oct 19 13:13:40 test systemd-networkd[691]: ens192: Re-configuring with /run/systemd/network/10-netplan-n1p1.network
Oct 19 13:13:40 test systemd-networkd[691]: bond_all: Re-configuring with /run/systemd/network/10-netplan-bond_all.network
Oct 19 13:13:40 test systemd-networkd[691]: ens192: Link DOWN
Oct 19 13:13:40 test systemd-networkd[691]: ens192: Lost carrier
Oct 19 13:13:40 test systemd-networkd[691]: ens192: Link UP
Oct 19 13:13:40 test kernel: vmxnet3 0000:0b:00.0 ens192: intr type 3, mode 0, 5 vectors allocated
Oct 19 13:13:40 test kernel: vmxnet3 0000:0b:00.0 ens192: NIC Link is Up 10000 Mbps
Oct 19 13:13:40 test systemd-networkd[691]: ens192: Gained carrier

/run/systemd/network/10-netplan-n1p1.network:

[Match]
Name=ens192

[Network]
LinkLocalAddressing=no
Bond=bond_all

/run/systemd/network/10-netplan-bond_all.network:

[Match]
Name=bond_all

[Network]
LinkLocalAddressing=ipv6
Address=10.1.1.206/24
DNS=10.1.1.1
ConfigureWithoutCarrier=yes

[Route]
Destination=0.0.0.0/0
Gateway=10.1.1.1

Additional program output to the terminal or log subsystem illustrating the issue

No response
@Garagoth Garagoth added the bug 🐛 Programming errors, that need preferential fixing label Oct 19, 2022
yuwata added a commit to yuwata/systemd that referenced this issue Oct 27, 2022
@yuwata
network: skip to reassign master ifindex if already set
f2a7853 
Otherwise, the slave interface may bring down.

Fixes systemd#25067.
yuwata added a commit to yuwata/systemd that referenced this issue Oct 27, 2022
@yuwata
network: skip to reassign master ifindex if already set
bd16899 
Otherwise, the slave interface may go down, especially when the master
is bond.

Fixes systemd#25067.
@yuwata yuwata mentioned this issue Oct 27, 2022
Merged
@yuwata
Copy link
Member

yuwata commented Oct 27, 2022

Fix is waiting in #25162.

yuwata added a commit to yuwata/systemd that referenced this issue Oct 27, 2022
@yuwata
network: skip to reassign master ifindex if already set
ebf95ef 
Otherwise, the slave interface may go down, especially when the master
is bond.

Fixes systemd#25067.
bluca pushed a commit that referenced this issue Oct 31, 2022
@yuwata @bluca
network: skip to reassign master ifindex if already set
9f913d3 
Otherwise, the slave interface may go down, especially when the master
is bond.

Fixes #25067.
d-hatayama pushed a commit to d-hatayama/systemd that referenced this issue Feb 15, 2023
@yuwata @d-hatayama
network: skip to reassign master ifindex if already set
658d5d9 
Otherwise, the slave interface may go down, especially when the master
is bond.

Fixes systemd#25067.
valentindavid pushed a commit to valentindavid/systemd that referenced this issue Aug 8, 2023
@yuwata @keszybz
network: skip to reassign master ifindex if already set
2f8f1d9 
Otherwise, the slave interface may go down, especially when the master
is bond.

Fixes systemd#25067.

(cherry picked from commit 9f913d3)
@Wouter0100 Wouter0100 mentioned this issue Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Programming errors, that need preferential fixing network
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

network: skip to reassign master ifindex if already set yuwata/systemd
2 participants
@Garagoth @yuwata