Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickAck shall belong also to [DHCP] section to allow enable quickack #25906

Closed
rdslw opened this issue Jan 1, 2023 · 1 comment · Fixed by #26071
Closed

QuickAck shall belong also to [DHCP] section to allow enable quickack #25906

rdslw opened this issue Jan 1, 2023 · 1 comment · Fixed by #26071
Labels
network RFE 🎁 Request for Enhancement, i.e. a feature request

Comments

@rdslw
Copy link

rdslw commented Jan 1, 2023

systemd version the issue has been seen with

systemd 252 (252.4-2-arch)

Used distribution

Archlinux

Linux kernel version used

6.1.2-zen2

CPU architectures issue was seen on

x86_64

Component

systemd-networkd

Expected behaviour you didn't see

Ability to add 'QuickAck=true' parameter to ALL routes being added by networkd for dhcp, the same way as Metric=X is used in [DHCP] section.

Currently you can use QuickAck= only on [Route] secions, which I consider a bug, as it does NOT allow to use quickack at all if using dhcp.

There are usually 3 routing table entries being added if using dhcp configuration, being:
default, gateway, gateway network

Currently it is impossible to tell systemd to use quickack setting in such case.

This is highly needed due to recent discovery https://withinboredom.info/blog/2022/12/29/golang-is-evil-on-shitty-networks/
and original John Nagle comments: https://news.ycombinator.com/item?id=10608356 that quickack should be enabled by default (it is not).

@rdslw rdslw added the bug 🐛 Programming errors, that need preferential fixing label Jan 1, 2023
@rdslw rdslw changed the title QuickAck shall belong also to [DHCP] seciont QuickAck shall belong also to [DHCP] section to allow enable quickack Jan 1, 2023
@yuwata yuwata added RFE 🎁 Request for Enhancement, i.e. a feature request and removed bug 🐛 Programming errors, that need preferential fixing labels Jan 16, 2023
yuwata added a commit to yuwata/systemd that referenced this issue Jan 16, 2023
@yuwata
Copy link
Member

yuwata commented Jan 16, 2023

Waiting in #26071.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network RFE 🎁 Request for Enhancement, i.e. a feature request
Development

Successfully merging a pull request may close this issue.

2 participants